MAINT: Rename sample-peds, feature-peds, pprs and peds-simulation #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok so just making sure i understand - you're also removing the original peds method since you've fully replaced this functionality with pedf and prdf, correct? |
|
Yep! I don't have multiple 'peds' methods anymore so a pipeline that can run multiple peds methods felt weird so I decided to remove it in favor of pedf and prdf. |
lizgehret
requested changes
Nov 13, 2024
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
|
Thanks for the review. I have addressed your suggestions and also I changed the description of detect-donor-indicators to be detect donor indicator features. Thanks for catching that as well. |
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample-peds -> pedf
feature-peds -> prdf
pprs -> pprf
peds-simulation -> peds-permutation-test